Skip to content

fix(specs): userData is any type #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

fix(specs): userData is any type #4702

merged 2 commits into from
Apr 3, 2025

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 3, 2025

🧭 What and Why

fixes algolia/algoliasearch-client-go#769

🎟 JIRA Ticket: DI-3692

The userData of the index settings can be anything since it's not serialized by the API, I tried with a string, an array, and a object and they are all accepted by the API.

I found out that we can generate the any type in all languages by just omitting the type, but this means its also nullable, not sure how to remove that.

@millotp millotp requested a review from a team as a code owner April 3, 2025 14:35
@millotp millotp requested review from Fluf22 and shortcuts April 3, 2025 14:35
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 3, 2025

✔️ Code generated!

Name Link
🪓 Triggered by d3c525e68ac854333fd3ed247f1d002742d9ce6f
🍃 Generated commit d1fc052a9655bb1cbc776a40baeecfb31bd823d4
🌲 Generated branch generated/fix/userData
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1598
go 1572
php 1468
csharp 1257
python 1119
java 1084
ruby 822
swift 806
scala 23

shortcuts
shortcuts previously approved these changes Apr 3, 2025
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUGE

let's see if it works for any language 🥶

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EASY

@millotp millotp merged commit dbaef66 into main Apr 3, 2025
28 checks passed
@millotp millotp deleted the fix/userData branch April 3, 2025 15:27
algolia-bot added a commit that referenced this pull request Apr 3, 2025
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Apr 3, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Apr 3, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 3, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Apr 3, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Apr 3, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: cannot unmarshal response with user data
3 participants