-
Notifications
You must be signed in to change notification settings - Fork 21
fix(specs): userData is any type #4702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HUGE
let's see if it works for any language 🥶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EASY
Co-authored-by: Pierre Millot <[email protected]>
algolia/api-clients-automation#4702 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia/api-clients-automation#4702 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia/api-clients-automation#4702 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia/api-clients-automation#4702 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia/api-clients-automation#4702 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia/api-clients-automation#4702 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
🧭 What and Why
fixes algolia/algoliasearch-client-go#769
🎟 JIRA Ticket: DI-3692
The
userData
of the index settings can be anything since it's not serialized by the API, I tried with a string, an array, and a object and they are all accepted by the API.I found out that we can generate the
any
type in all languages by just omitting thetype
, but this means its also nullable, not sure how to remove that.