Skip to content

fix(specs): condition cant be numeric filter #4726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

fix(specs): condition cant be numeric filter #4726

merged 2 commits into from
Apr 10, 2025

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Apr 9, 2025

🧭 What and Why

Amend the description for the 'condition' object about the limitations of the 'filter' parameter.

🎟 JIRA Ticket: N/A

Changes included:

  • Fix a typo
  • Add that you can't use numeric filters or combinations of filters with OR

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 9, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 48b5b9fbb76cf68514b43ea99186f36a8d012149
🍃 Generated commit 410b3a34b2b1e686d4e1550a37facb84dea3ab8b
🌲 Generated branch generated/fix/rules
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1642
go 1601
php 1471
csharp 1450
python 1108
java 1088
swift 862
ruby 813
scala 23

@kai687 kai687 marked this pull request as ready for review April 9, 2025 08:09
@kai687 kai687 requested a review from a team as a code owner April 9, 2025 08:09
@kai687 kai687 requested review from Fluf22 and millotp April 9, 2025 08:09
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ✅

@millotp millotp enabled auto-merge (squash) April 10, 2025 08:15
@millotp millotp merged commit 369c142 into main Apr 10, 2025
28 checks passed
@millotp millotp deleted the fix/rules branch April 10, 2025 08:22
algolia-bot added a commit that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants