Skip to content

fix(specs): event.status can be null #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

fix(specs): event.status can be null #4727

merged 3 commits into from
Apr 10, 2025

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 10, 2025

🧭 What and Why

🎟 JIRA Ticket: CR-8289

The status field is null for log type events.
Fix the python generation that didn't support nullable enums.

@millotp millotp self-assigned this Apr 10, 2025
@millotp millotp requested a review from a team as a code owner April 10, 2025 10:00
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 10, 2025

✔️ Code generated!

Name Link
🪓 Triggered by da4ba14052831d589d3d8650d8260ea333abf421
🍃 Generated commit dae19094bce6215cee3776c20d53cdbe55f97289
🌲 Generated branch generated/fix/status-null
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1710
go 1612
php 1546
csharp 1307
java 1125
python 1119
swift 875
ruby 767
scala 23

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@millotp millotp merged commit 1911d22 into main Apr 10, 2025
28 checks passed
@millotp millotp deleted the fix/status-null branch April 10, 2025 15:25
algolia-bot added a commit that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Apr 10, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants