Skip to content

chore: fix setup step #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2022
Merged

chore: fix setup step #477

merged 3 commits into from
May 6, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented May 6, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • setup is skipped when client a re-generated, which prevent the CTS to run
  • cache was computed on the bundled specs instead of hand written ones
  • building all specs did not worked anymore

🧪 Test

CI :D

@netlify
Copy link

netlify bot commented May 6, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ec2d122
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6274d86f7bbae70009ea6b71
😎 Deploy Preview https://deploy-preview-477--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 6, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts requested a review from millotp May 6, 2022 08:12
@shortcuts shortcuts self-assigned this May 6, 2022
@shortcuts shortcuts enabled auto-merge (squash) May 6, 2022 08:25
@@ -184,7 +184,7 @@ buildCommand
const outputFormat = outputJson ? 'json' : 'yml';

let clientsTodo = client;
if (client === ['all']) {
if (client[0] === 'all') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants