feat(javascript): add accountCopyIndex helper
#4798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
force-pushed
the
feat/javascript-account-copy-index
branch
from
92da4a7 to
dec43f7
Compare
millotp
reviewed
Apr 29, 2025
| destinationAppID: string; | ||
|
|
||
| /** | ||
| * The API Key of the `destinationAppID` to write the index to, must have write ACLs. |
There was a problem hiding this comment.
maybe be more precise with an ACL list ? we have the Required ACL section in most endpoints
| filterPromotes: true, | ||
| promote: [ | ||
| { | ||
| objectIDs: ['\u00C6on Flux'], |
algolia-bot
added a commit
that referenced
this pull request
Apr 30, 2025
…skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Apr 30, 2025
algolia/api-clients-automation#4798 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3725
Changes included:
This helper wasn't added to the generated clients as we did not had the other internal helpers that are used, but now that we have them, and customer requests this method to be added, it's pretty easy to do so!