chore(test): check that the response can contain unknown field #4805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
approved these changes
May 12, 2025
|
|
||
| // languages that just put the response in a map, there is no strict parsing or types to match. | ||
| const isLaxLanguage = (lang: string) => { | ||
| return lang === 'dart' || lang === 'javascript' || lang === 'python' || lang === 'php'; |
There was a problem hiding this comment.
can this be moved as an option in the tests field of the clients config? I tried to update some scripts to remove those inline conditions where possible, having the json schema there as well helps us better describing things
algolia-bot
added a commit
that referenced
this pull request
May 13, 2025
… (generated) [skip ci] Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
May 13, 2025
…ated) algolia/api-clients-automation#4805 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Add a test that assert that unknown fields doesn't make the deserialization fail, at the root of the object, or nested in a oneOf inside an array inside a object.