Skip to content

fix(specs): wrong ACL for getSettings #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix(specs): wrong ACL for getSettings #4933

merged 1 commit into from
Jun 4, 2025

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jun 4, 2025

🧭 What and Why

getSettings should require settings ACL.

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 4, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by a8fa27295911acb7a96aeaaf2ef9277f9f08ba72
🍃 Generated commit 4c15d11bfffdcfb85b3c9cb8a9a2340447f309a5
🌲 Generated branch generated/fix/settings-acl
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1763
javascript 1624
php 1498
csharp 1416
java 1086
python 1070
ruby 747
swift 368
scala 23

@kai687 kai687 marked this pull request as ready for review June 4, 2025 08:05
@kai687 kai687 requested a review from a team as a code owner June 4, 2025 08:05
@kai687 kai687 requested review from Fluf22 and shortcuts June 4, 2025 08:05
@shortcuts shortcuts merged commit 1951e4d into main Jun 4, 2025
28 checks passed
@shortcuts shortcuts deleted the fix/settings-acl branch June 4, 2025 10:30
algolia-bot added a commit that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants