chore(scripts): factor git repo id #499
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| @@ -5,7 +5,6 @@ | |||
| "javascript-search": { | |||
There was a problem hiding this comment.
I believe there are others in this file that we could also factor like apiPackage for JS etc.
There was a problem hiding this comment.
I found those:
js:
apiPackage
java:
- groupId
- apiPackage
- invokerPackage
- library
php:
- I can only see some leftovers for
php-query-suggestions
There was a problem hiding this comment.
Thanks for the list ! I removed all of it
millotp
force-pushed
the
chore/common-gitrepoid
branch
from
925c6b0 to
02b74a0
Compare
millotp
force-pushed
the
fix/java-release-name
branch
2 times, most recently
from
36b225f to
ae4d23b
Compare
millotp
force-pushed
the
chore/common-gitrepoid
branch
from
02b74a0 to
422e8d0
Compare
millotp
requested review from
a team,
eunjae-lee,
damcou and
shortcuts
and removed request for
a team and
eunjae-lee
millotp
force-pushed
the
chore/common-gitrepoid
branch
from
422e8d0 to
5b80150
Compare
| @@ -72,6 +72,7 @@ public void processOpts() { | |||
| // generator specific options | |||
| setApiNameSuffix(Utils.API_SUFFIX); | |||
| setParameterNamingConvention("camelCase"); | |||
| additionalProperties.put("invokerPackage", "Algolia\\AlgoliaSearch"); | |||
There was a problem hiding this comment.
It wasn't possible to move it in clients.config.json instead ?
There was a problem hiding this comment.
it could be the purpose of clients.config.json is to make data available to everything: scripts, generators, ci...
here it's only needed in the generators so I put it here
There was a problem hiding this comment.
Ok, I thought the main goal was just to deduplicate the config, but whatever
There was a problem hiding this comment.
the openapitools.json is fed directly into the generators, it is for deduplicating config so we can put it in the common place, that is generators
| @@ -88,4 +89,8 @@ public void processOpts() { | |||
| ) | |||
| ); | |||
| } | |||
|
|
|||
| public String getComposerPackageName() { | |||
| return "algolia/algoliasearch-client-php"; | |||
There was a problem hiding this comment.
The default method which computes the name doesn't work anymore without gitRepoId in the openapitool.json file ?
There was a problem hiding this comment.
yes I don't really get why, there is a bug in openapi generator where if no value is provided for gitRepoId, it will default to GIT_REPO_ID (stupid code) and break the getComposePackageName function.
But this does the same in the end
|
Thanks for the review :) |
🧭 What and Why
remove almost all guessable value from
openapitools.jsonand put it inclients.config.jsonor generators (because it's defined per language).This doesn't change much, just simplify some logic.
🧪 Test
CI