Skip to content

fix(javascript): remove unused methods of algoliasearch-lite #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2022
Merged

fix(javascript): remove unused methods of algoliasearch-lite #524

merged 1 commit into from
May 20, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Some of those methods are unused in algoliasearch-lite, we now give the strict minimum.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team May 20, 2022 08:41
@shortcuts shortcuts self-assigned this May 20, 2022
@shortcuts shortcuts requested review from eunjae-lee and damcou and removed request for a team May 20, 2022 08:41
@netlify
Copy link

netlify bot commented May 20, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit e37ffc6
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6287544f89529d0008182965

@shortcuts shortcuts requested review from millotp and removed request for eunjae-lee May 20, 2022 08:42
@algolia-bot
Copy link
Collaborator

algolia-bot commented May 20, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts
Copy link
Member Author

cc @Haroenv

millotp
millotp approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

searchForFacetValues and multipleQueries can all be done with search right ?

@shortcuts
Copy link
Member Author

searchForFacetValues and multipleQueries can all be done with search right ?

multipleQueries does not exists anymore so it's search now actually, and we don't need searchSingleIndex here

And yes for SFFV!

@shortcuts shortcuts merged commit 588539c into main May 20, 2022
@shortcuts shortcuts deleted the fix/algoliasearch-lite-methods branch May 20, 2022 10:47
@shortcuts shortcuts mentioned this pull request May 23, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp