fix: use object for CTS parameters #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
force-pushed
the
fix/cts-param-array
branch
2 times, most recently
from
5ee34a5 to
564069f
Compare
shortcuts
reviewed
Jan 6, 2022
millotp
force-pushed
the
fix/cts-param-array
branch
from
564069f to
15c2811
Compare
shortcuts
previously approved these changes
Jan 6, 2022
doc/CTS.md
Outdated
| "method": "the method to call on the API Client", | ||
| "parameters": { | ||
| // Object of all parameters with their name, tobe used for languages that require the parameter name | ||
| "parameter name": "value", |
There was a problem hiding this comment.
Suggested change
| "parameter name": "value", | |
| "parameterName": "value", |
shortcuts
approved these changes
Jan 6, 2022
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Use object for every parameters in the CTS, to accommodate language like javascript where you need to pass the parameters name too.
Also create a parameter array for other languages.
The test are now ordered alphabetically, because on some machines the file order was messed up and generating a different output.
Changes included:
🧪 Test
yarn docker cts:generateyarn docker cts:test