Skip to content

chore(ci): add specs lint job #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2022
Merged

chore(ci): add specs lint job #66

merged 3 commits into from
Jan 6, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

I forgot to add the specs linting job in the new CI

🧪 Test

CI :D

@shortcuts shortcuts requested a review from millotp January 6, 2022 10:40
@shortcuts shortcuts self-assigned this Jan 6, 2022
@shortcuts shortcuts marked this pull request as ready for review January 6, 2022 10:40
millotp
millotp approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! The rule to enforce no quote is not quite working, in the spec some $ref have quote and some don't, do you know why ?

@shortcuts
Copy link
Member Author

The rule to enforce no quote is not quite working, in the spec some $ref have quote and some don't, do you know why ?

It seems that the rule don't run on the $refs, I'll check the plugin repo

@shortcuts shortcuts merged commit aad17bb into main Jan 6, 2022
@shortcuts shortcuts deleted the chore/ci-specs-lint branch January 6, 2022 10:53
shortcuts added a commit that referenced this pull request Apr 22, 2022
@shortcuts
chore(ci): add specs lint job (#66)
e50175e
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortcuts @millotp