Skip to content

feat(js): pass searchParams to EchoRequester, update CTS #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 10, 2022
Merged

feat(js): pass searchParams to EchoRequester, update CTS #70

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c4950a8
feat(cts): add tests for `analytics`
shortcuts Jan 7, 2022
bfbf975
fix: tests, date
shortcuts Jan 7, 2022
a14b792
feat(js): pass `searchParams` to `EchoRequester`, update CTS
shortcuts Jan 7, 2022
aad0c09
tests: add `searchParams` values
shortcuts Jan 7, 2022
6cc05ef
use `searchParams` object
shortcuts Jan 7, 2022
4e9cbcd
Merge branch 'main' into feat/APIC-247/cts-search-parameters
shortcuts Jan 10, 2022
db35de7
fix(specs): analytics paths and params (#73)
shortcuts Jan 10, 2022
61eae55
remove `objectContaining` on `searchParams`
shortcuts Jan 10, 2022
f9c18d2
split assertions, make `EchoRequester` return undefined
shortcuts Jan 10, 2022
78fa21d
fix typescript syntax
shortcuts Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions clients/algoliasearch-client-javascript/client-analytics/utils/requester/EchoRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ type AdditionalContent = {
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
searchParams: Record<string, any> | undefined;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
function searchParamsWithoutUA(
params: URLSearchParams
): Record<string, any> | undefined {
const searchParams = {};

for (const [k, v] of params) {
Expand All @@ -21,7 +23,7 @@ function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
searchParams[k] = v;
}

return searchParams;
return Object.entries(searchParams).length === 0 ? undefined : searchParams;
}

export class EchoRequester extends Requester {
Expand All @@ -31,7 +33,7 @@ export class EchoRequester extends Requester {

send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
{ data, ...originalRequest }: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
Expand All @@ -43,9 +45,15 @@ export class EchoRequester extends Requester {
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};
const originalData =
data && Object.entries(data).length > 0 ? data : undefined;

return Promise.resolve({
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
content: JSON.stringify({
...originalRequest,
...additionalContent,
data: originalData,
}),
isTimedOut: false,
status: this.status,
});
Expand Down
18 changes: 13 additions & 5 deletions clients/algoliasearch-client-javascript/client-insights/utils/requester/EchoRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ type AdditionalContent = {
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
searchParams: Record<string, any> | undefined;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
function searchParamsWithoutUA(
params: URLSearchParams
): Record<string, any> | undefined {
const searchParams = {};

for (const [k, v] of params) {
Expand All @@ -21,7 +23,7 @@ function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
searchParams[k] = v;
}

return searchParams;
return Object.entries(searchParams).length === 0 ? undefined : searchParams;
}

export class EchoRequester extends Requester {
Expand All @@ -31,7 +33,7 @@ export class EchoRequester extends Requester {

send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
{ data, ...originalRequest }: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
Expand All @@ -43,9 +45,15 @@ export class EchoRequester extends Requester {
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};
const originalData =
data && Object.entries(data).length > 0 ? data : undefined;

return Promise.resolve({
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
content: JSON.stringify({
...originalRequest,
...additionalContent,
data: originalData,
}),
isTimedOut: false,
status: this.status,
});
Expand Down
18 changes: 13 additions & 5 deletions ...s/algoliasearch-client-javascript/client-personalization/utils/requester/EchoRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ type AdditionalContent = {
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
searchParams: Record<string, any> | undefined;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
function searchParamsWithoutUA(
params: URLSearchParams
): Record<string, any> | undefined {
const searchParams = {};

for (const [k, v] of params) {
Expand All @@ -21,7 +23,7 @@ function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
searchParams[k] = v;
}

return searchParams;
return Object.entries(searchParams).length === 0 ? undefined : searchParams;
}

export class EchoRequester extends Requester {
Expand All @@ -31,7 +33,7 @@ export class EchoRequester extends Requester {

send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
{ data, ...originalRequest }: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
Expand All @@ -43,9 +45,15 @@ export class EchoRequester extends Requester {
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};
const originalData =
data && Object.entries(data).length > 0 ? data : undefined;

return Promise.resolve({
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
content: JSON.stringify({
...originalRequest,
...additionalContent,
data: originalData,
}),
isTimedOut: false,
status: this.status,
});
Expand Down
18 changes: 13 additions & 5 deletions clients/algoliasearch-client-javascript/client-search/utils/requester/EchoRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ type AdditionalContent = {
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
searchParams: Record<string, any> | undefined;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
function searchParamsWithoutUA(
params: URLSearchParams
): Record<string, any> | undefined {
const searchParams = {};

for (const [k, v] of params) {
Expand All @@ -21,7 +23,7 @@ function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
searchParams[k] = v;
}

return searchParams;
return Object.entries(searchParams).length === 0 ? undefined : searchParams;
}

export class EchoRequester extends Requester {
Expand All @@ -31,7 +33,7 @@ export class EchoRequester extends Requester {

send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
{ data, ...originalRequest }: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
Expand All @@ -43,9 +45,15 @@ export class EchoRequester extends Requester {
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};
const originalData =
data && Object.entries(data).length > 0 ? data : undefined;

return Promise.resolve({
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
content: JSON.stringify({
...originalRequest,
...additionalContent,
data: originalData,
}),
isTimedOut: false,
status: this.status,
});
Expand Down
18 changes: 13 additions & 5 deletions clients/algoliasearch-client-javascript/recommend/utils/requester/EchoRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ type AdditionalContent = {
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
searchParams: Record<string, any> | undefined;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
function searchParamsWithoutUA(
params: URLSearchParams
): Record<string, any> | undefined {
const searchParams = {};

for (const [k, v] of params) {
Expand All @@ -21,7 +23,7 @@ function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
searchParams[k] = v;
}

return searchParams;
return Object.entries(searchParams).length === 0 ? undefined : searchParams;
}

export class EchoRequester extends Requester {
Expand All @@ -31,7 +33,7 @@ export class EchoRequester extends Requester {

send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
{ data, ...originalRequest }: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
Expand All @@ -43,9 +45,15 @@ export class EchoRequester extends Requester {
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};
const originalData =
data && Object.entries(data).length > 0 ? data : undefined;

return Promise.resolve({
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
content: JSON.stringify({
...originalRequest,
...additionalContent,
data: originalData,
}),
isTimedOut: false,
status: this.status,
});
Expand Down
18 changes: 13 additions & 5 deletions clients/algoliasearch-client-javascript/utils/requester/EchoRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ type AdditionalContent = {
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
searchParams: Record<string, any> | undefined;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
function searchParamsWithoutUA(
params: URLSearchParams
): Record<string, any> | undefined {
const searchParams = {};

for (const [k, v] of params) {
Expand All @@ -21,7 +23,7 @@ function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
searchParams[k] = v;
}

return searchParams;
return Object.entries(searchParams).length === 0 ? undefined : searchParams;
}

export class EchoRequester extends Requester {
Expand All @@ -31,7 +33,7 @@ export class EchoRequester extends Requester {

send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
{ data, ...originalRequest }: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
Expand All @@ -43,9 +45,15 @@ export class EchoRequester extends Requester {
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};
const originalData =
data && Object.entries(data).length > 0 ? data : undefined;

return Promise.resolve({
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
content: JSON.stringify({
...originalRequest,
...additionalContent,
data: originalData,
}),
isTimedOut: false,
status: this.status,
});
Expand Down
5 changes: 4 additions & 1 deletion tests/CTS/clients/analytics/getAverageClickPosition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
},
"request": {
"path": "/2/clicks/averageClickPosition",
"method": "GET"
"method": "GET",
"searchParams": {
"index": "index"
}
}
},
{
Expand Down
5 changes: 4 additions & 1 deletion tests/CTS/clients/analytics/getClickPositions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
},
"request": {
"path": "/2/clicks/positions",
"method": "GET"
"method": "GET",
"searchParams": {
"index": "index"
}
}
},
{
Expand Down
5 changes: 4 additions & 1 deletion tests/CTS/clients/analytics/getClickThroughRate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
},
"request": {
"path": "/2/clicks/clickThroughRate",
"method": "GET"
"method": "GET",
"searchParams": {
"index": "index"
}
}
},
{
Expand Down
5 changes: 4 additions & 1 deletion tests/CTS/clients/analytics/getConversationRate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
},
"request": {
"path": "/2/conversions/conversionRate",
"method": "GET"
"method": "GET",
"searchParams": {
"index": "index"
}
}
},
{
Expand Down
5 changes: 4 additions & 1 deletion tests/CTS/clients/analytics/getNoClickRate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
},
"request": {
"path": "/2/searches/noClickRate",
"method": "GET"
"method": "GET",
"searchParams": {
"index": "index"
}
}
},
{
Expand Down
5 changes: 4 additions & 1 deletion tests/CTS/clients/analytics/getNoResultsRate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
},
"request": {
"path": "/2/searches/noResultRate",
"method": "GET"
"method": "GET",
"searchParams": {
"index": "index"
}
}
},
{
Expand Down
5 changes: 4 additions & 1 deletion tests/CTS/clients/analytics/getSearchesCount.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
},
"request": {
"path": "/2/searches/count",
"method": "GET"
"method": "GET",
"searchParams": {
"index": "index"
}
}
},
{
Expand Down
5 changes: 4 additions & 1 deletion tests/CTS/clients/analytics/getSearchesNoClicks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
},
"request": {
"path": "/2/searches/noClicks",
"method": "GET"
"method": "GET",
"searchParams": {
"index": "index"
}
}
},
{
Expand Down
Loading