-
Notifications
You must be signed in to change notification settings - Fork 21
chore: fix changelog format #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's hard to try the release process but this looks good, way better changelog !
- 23a72c39 fix(specs): correct type for highlightResult and snippetResult (#783) | ||
- a11e84da fix(specs): fix missing params and types (#772) | ||
- bc14a8c5 feat(specs): Add tags to the settings and search params (#768) | ||
- [23a72c39](https://github.com/algolia/api-clients-automation/commit/23a72c39) fix(specs): correct type for highlightResult and snippetResult (#783) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blasphemy to update the existing changelog 😱 !
it's like trying to cover a murder ahah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:DD I don't see what you mean
2a23726
to
c677f16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! final thing about authors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changelog couldn't be better !
algolia/api-clients-automation#791 Co-authored-by: Clément Vannicatte <[email protected]>
algolia/api-clients-automation#791 Co-authored-by: Clément Vannicatte <[email protected]>
algolia/api-clients-automation#791 Co-authored-by: Clément Vannicatte <[email protected]>
algolia/api-clients-automation#791 Co-authored-by: Clément Vannicatte <[email protected]>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-570
Changes included:
Content in the changelogs was not usable, we now provide links to the hash commits, and their author.
Updates in this PR:
git
logic introduced inscripts/release/updateAPIVersions.ts
to where it belongs inscripts/release/createReleasePR.ts
🧪 Test