fix: move the CTS around to prepare for multi-languages support #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
changed the title
millotp
force-pushed
the
fix/use-multiplexer-cts
branch
from
f09e560 to
73692c8
Compare
millotp
force-pushed
the
fix/use-multiplexer-cts
branch
from
73692c8 to
5b80d36
Compare
millotp
requested review from
shortcuts and
damcou
and removed request for
shortcuts
shortcuts
reviewed
Jan 13, 2022
Comment on lines
+1
to
+7
| import fsp from 'fs/promises'; | ||
|
|
||
| export async function loadRequestsTemplate(language: string): Promise<string> { | ||
| return ( | ||
| await fsp.readFile(`CTS/templates/${language}/requests.mustache`) | ||
| ).toString(); | ||
| } |
There was a problem hiding this comment.
This could be in utils until we have the clients/responses tests
There was a problem hiding this comment.
We already have some with #88, I will leave it here as ground work.
Merged
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-253
Split the CTS into more parts, to allow for more languages, other tests than requests (like client tests) and use the multiplexer script to reduce duplication.
Changes included:
requestsfoldertests/requestspackage.jsonfor the javascript CTS, separated from the generationjavaCTS🧪 Test
Now all CTS operation require to be run inside of docker too, to simplify everything.