-
Notifications
You must be signed in to change notification settings - Fork 21
fix: move the CTS around to prepare for multi-languages support #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f09e560
to
73692c8
Compare
73692c8
to
5b80d36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good initiative!
import fsp from 'fs/promises'; | ||
|
||
export async function loadRequestsTemplate(language: string): Promise<string> { | ||
return ( | ||
await fsp.readFile(`CTS/templates/${language}/requests.mustache`) | ||
).toString(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be in utils
until we have the clients/responses tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have some with #88, I will leave it here as ground work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! Nice
🧭 What and Why
🎟 JIRA Ticket: APIC-253
Split the CTS into more parts, to allow for more languages, other tests than requests (like client tests) and use the multiplexer script to reduce duplication.
Changes included:
requests
foldertests/requests
package.json
for the javascript CTS, separated from the generationjava
CTS🧪 Test
Now all CTS operation require to be run inside of docker too, to simplify everything.