Skip to content

chore(deps): precise version for yarn and fix java formatter #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 18, 2022

🧭 What and Why

Using the recursive regex matcher we can make sure that only version inside devDependencies are updated.
Also remove the v from java formatter version.

@millotp millotp self-assigned this Jul 18, 2022
@netlify
Copy link

netlify bot commented Jul 18, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 57a5cb0
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62d52bba0f3af60008e307ef

@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team July 18, 2022 09:45
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 18, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my comment if it's not the case

nice :)

Comment on lines +49 to +50
"\"devDependencies\":\\s*{[^}]*}",
"\\s\"(?<depName>.*?)\": \"(?<currentValue>.*?)\",?\\s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't those regex independent? Or does the array order defines the match nest level or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@millotp millotp Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's only possible with the matchStringStrategy: "recursive" mode, otherwise they are independent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's sick

@millotp millotp merged commit 1f395bf into main Jul 18, 2022
@millotp millotp deleted the chore/precise-renovate branch July 18, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants