-
Notifications
You must be signed in to change notification settings - Fork 21
chore(deps): precise version for yarn and fix java formatter #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore my comment if it's not the case
nice :)
"\"devDependencies\":\\s*{[^}]*}", | ||
"\\s\"(?<depName>.*?)\": \"(?<currentValue>.*?)\",?\\s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't those regex independent? Or does the array order defines the match nest level or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recursive match string ftw !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's only possible with the matchStringStrategy: "recursive"
mode, otherwise they are independent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's sick
🧭 What and Why
Using the recursive regex matcher we can make sure that only version inside
devDependencies
are updated.Also remove the
v
from java formatter version.