feat(scripts): git hook to format generators #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
requested review from
damcou and
shortcuts
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Jul 21, 2022
| @@ -1,4 +1,5 @@ | |||
| #!/bin/sh | |||
| . "$(dirname "$0")/_/husky.sh" | |||
|
|
|||
| ./scripts/ci/husky/pre-commit.js | |||
| ./scripts/husky/pre-commit.js | |||
| ./scripts/husky/format-generators.js | |||
There was a problem hiding this comment.
Can you add the JSON one too? You can have a common format
package.json
Outdated
| @@ -13,6 +13,7 @@ | |||
| "clean": "rm -rf **/dist **/build **/node_modules **/.gradle **/vendor || true", | |||
| "cli": "yarn workspace scripts ts-node --transpile-only ./cli/index.ts", | |||
| "docker": "docker exec -it dev yarn cli $*", | |||
| "docker:no-tty": "docker exec -t dev yarn cli $*", | |||
There was a problem hiding this comment.
if it's only used in the script maybe it's worth having the raw command, wdyt?
There was a problem hiding this comment.
yeah good idea again !
millotp
changed the title
shortcuts
force-pushed
the
feat/hook-generators
branch
from
c45181d to
988836d
Compare
shortcuts
approved these changes
Jul 25, 2022
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-592
I'm tired of seeing the CI fail because of the generators being unformatted, so here is a hook to format generators everytime there are changes.
We need the
docker:no-ttyscript because we don't have a tty inside the hook.Changes included:
format-generatorsscript🧪 Test
Try modifying a generator file and commit it.