Skip to content

fix(ci): only run size check on release #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jul 26, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

We don't always generate/build all clients, therefore we can't run bundlesize on every runs. I've changed the condition to only run on prepare release PRs for now, and will try to find a conditional way. Ticket added here: https://algolia.atlassian.net/browse/APIC-596

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Jul 26, 2022
@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 24940dd
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62e0060b4ebe2500088a9a9b

@shortcuts shortcuts changed the title fix(ci): remove size check on CI fix(ci): only run size check on release Jul 26, 2022
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 26, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts requested a review from bodinsamuel July 26, 2022 15:24
@shortcuts shortcuts enabled auto-merge (squash) July 26, 2022 15:29
@shortcuts shortcuts merged commit 1320647 into main Jul 26, 2022
@shortcuts shortcuts deleted the chore/remove-bundlesize-ci-check branch July 26, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants