Skip to content

chore: restructure folder #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 14, 2022
Merged

chore: restructure folder #89

merged 10 commits into from
Jan 14, 2022

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Jan 14, 2022

🧭 What and Why

Changes included:

This PR restructure the folders:

  • cts
    • methods
      • requests
      • responses
    • client
    • integrations

@@ -30,8 +30,3 @@ export type CTSBlock = {
export type CTS = {
requests: CTSBlock[];
};

export const extensionForLanguage: Record<string, string> = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved to to utils, because it's more like util than a type. WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it makes sense ! Do you plan on expanding inside the cts folder or create another folder for the clients tests ?

@eunjae-lee eunjae-lee requested a review from millotp January 14, 2022 10:09
@shortcuts
Copy link
Member

Doing a test on the CI, @eunjae-lee can you please edit a random spec file to make it intentionally throw? bad indent or something similar

@eunjae-lee eunjae-lee changed the title chore: restructure folder for cts chore: restructure folder Jan 14, 2022
millotp
millotp previously approved these changes Jan 14, 2022
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me 👍

@eunjae-lee eunjae-lee requested a review from millotp January 14, 2022 13:50
@eunjae-lee eunjae-lee merged commit a3c6272 into main Jan 14, 2022
@eunjae-lee eunjae-lee deleted the chore/folder branch January 14, 2022 14:10
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
* chore: restructure folder for cts

* chore: fix script

* chore: restructure

* chore: testing ci

* revert: chore: testing ci

This reverts commit 1404650.

* chore: test ci

* chore: test ci 2

* chore: revert tests

* chore: move cts specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants