Skip to content

chore(ci): ensure pushed client is generated #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 18, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jan 18, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-267

Changes included:

  • Make CI throw if the client generated by the CI is different than the one on the PR.
  • Invalidate client cache by adding the hashFiles of the spec it requires.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Jan 18, 2022
@shortcuts shortcuts force-pushed the chore/check-diff-client branch from 3514ffb to 5ec3f0d Compare January 18, 2022 15:48
@shortcuts shortcuts requested review from a team and eunjae-lee and removed request for a team January 18, 2022 15:52
@shortcuts shortcuts marked this pull request as ready for review January 18, 2022 15:54
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! did you manage to test it ?

@shortcuts
Copy link
Member Author

Nice ! did you manage to test it ?

Yep! You can see the previous commits where it throws/pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants