feat(js): client common #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Name is here for the sake of the historical one, https://www.npmjs.com/package/@algolia/client-common suggest if you want to rename |
millotp
approved these changes
Jan 21, 2022
Comment on lines
+10
to
+12
| "generate": "yarn generate:methods:requets ${0:-javascript} ${1:-search} && yarn lint:fix", | ||
| "lint:fix": "yarn workspace javascript-tests lint:fix", | ||
| "start": "yarn build && yarn generate ${0:-javascript} ${1:-search}" |
There was a problem hiding this comment.
This makes more sense, I changed this in #100 to work with all languages
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-251
Changes included:
utilspackage toclient-common(to match the existing package in the current API client)Motivations
It was annoying to have everything copied while trying to bundle the JavaScript client and implementing the XHR requester. This allow us to only have one entry point.
I think it would make sense to break down this common package in mini-ones, some of those features might not be useful in every clients.
We can improve this package (or the sub ones) in many ways, but in the meantime it's already good for dev purposes.
🧪 Test
CI :D