-
Notifications
You must be signed in to change notification settings - Fork 496
network: stateless vote compression #6276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6276 +/- ##
==========================================
+ Coverage 51.65% 51.84% +0.19%
==========================================
Files 649 652 +3
Lines 86964 87433 +469
==========================================
+ Hits 44918 45331 +413
- Misses 39192 39236 +44
- Partials 2854 2866 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions so far.
Co-authored-by: Copilot <[email protected]>
Summary
Similar to #4589 this provides single-message vote compression without any shared context between messages. It removes msgpack control characters and field names, reducing the size of votes down to just the values present, plus a 2-byte header. It provides 25% smaller messages on typical votes, compared to 6-7% smaller for zstd, and is >20x faster than zstd's fastest levels.
Test Plan
Adds features to algodump for benchmarking and testing against network data(will submit as separate PR)