-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI observability upgrade #1587
AI observability upgrade #1587
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
+ Coverage 35.91% 43.50% +7.59%
==========================================
Files 69 76 +7
Lines 11576 12325 +749
==========================================
+ Hits 4157 5362 +1205
+ Misses 7104 6627 -477
- Partials 315 336 +21 |
@@ -345,7 +352,7 @@ func onHttpRequestBody(ctx wrapper.HttpContext, config AISecurityConfig, body [] | |||
reqParams.Add(k, v) | |||
} | |||
reqParams.Add("Signature", signature) | |||
err := config.client.Post(fmt.Sprintf("/?%s", reqParams.Encode()), [][2]string{{"User-Agent", AliyunUserAgent}}, nil, callback) | |||
err := config.client.Post(fmt.Sprintf("/?%s", reqParams.Encode()), [][2]string{{"User-Agent", AliyunUserAgent}}, nil, callback, 2000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
超时时间暴露一个配置可以让用户自己配吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kent Dong <[email protected]>
本次PR是对ai系列插件可视化的整体改进,具体涉及:
ai-statistic
get_property
获取route,否则在某些场景下可能会造成envoy退出ai-security-guard
ai-cache
ai-token-ratelimit