Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support baidu api key #1687

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Conversation

cr7258
Copy link
Collaborator

@cr7258 cr7258 commented Jan 17, 2025

Ⅰ. Describe what this PR did

百度当前也支持直接配置 API Key 来进行认证,并且也是目前官方推荐的方式。(文档)

CleanShot 2025-01-17 at 20 13 59@2x

该 PR 移除了原先通过 Access Key 和 Access Secret 获取 BearerToken 的逻辑,只保留新的通过 API Key 来请求的方式。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cr7258 cr7258 requested review from CH3CHO and rinfx as code owners January 17, 2025 12:17
@cr7258 cr7258 requested a review from johnlanni January 17, 2025 12:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.61%. Comparing base (ef31e09) to head (1b454d9).
Report is 274 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
+ Coverage   35.91%   43.61%   +7.70%     
==========================================
  Files          69       76       +7     
  Lines       11576    12358     +782     
==========================================
+ Hits         4157     5390    +1233     
+ Misses       7104     6630     -474     
- Partials      315      338      +23     

see 70 files with indirect coverage changes

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CH3CHO CH3CHO merged commit b1f625a into alibaba:main Jan 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants