feat: Support pushing multi-arch images to a custom image registry #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CH3CHO
requested review from
johnlanni,
Xunzhuo and
2456868764
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1815 +/- ##
==========================================
+ Coverage 35.91% 43.43% +7.52%
==========================================
Files 69 76 +7
Lines 11576 12278 +702
==========================================
+ Hits 4157 5333 +1176
+ Misses 7104 6616 -488
- Partials 315 329 +14 |
|
Can you give a fork as an example? |
https://github.com/CH3CHO/higress/ https://github.com/CH3CHO/higress/actions/runs/13521147267 |
Are you able to see the action run details of my own repo? |
johnlanni
added a commit
to johnlanni/higress
that referenced
this pull request
Mar 26, 2025
…istry (alibaba#1815)" This reverts commit 45fdd95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Support pushing multi-arch images to a custom image registry, so user can fork higress to his own GitHub repo, and use GitHub actions to build higress images.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
.github/workflows/build-image-and-push.yamlis shown completed modified due to the line break change from CRLF to LF. Actually, onlyBuild Docker Image and Pushsteps are changed.DOCKER_TARGETSenv and the env value is fixed in the upstream repository, we are unable to change them. So extra images with namepilotandproxyv2will be pushed to the custom repository with the same image repository URL. For example, if user configures to push images with namehub.foo.bar/higress/higress-pilot, bothhub.foo.bar/higress/higress-pilotandhub.foo.bar/higress/pilotwill be pushed, referring to the same digest.