Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow failover to distinguish between different endpoint of the same provider #1862

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

cr7258
Copy link
Collaborator

@cr7258 cr7258 commented Mar 7, 2025

Ⅰ. Describe what this PR did

相同的 provider 用户可能会配置不同的 endpoint,该 PR 将 provider 和 id 拼接起来作为 shared data 的 key,使得 failover 可以区分这种情况。

image image

Ⅱ. Does this pull request fix one issue?

fixes #1816

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cr7258 cr7258 requested review from CH3CHO and rinfx as code owners March 7, 2025 14:21
@cr7258 cr7258 changed the title feat: allow failover to distinguish between different endpoint of thesame provider feat: allow failover to distinguish between different endpoint of the same provider Mar 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.43%. Comparing base (ef31e09) to head (47f7e15).
Report is 335 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1862      +/-   ##
==========================================
+ Coverage   35.91%   43.43%   +7.52%     
==========================================
  Files          69       76       +7     
  Lines       11576    12301     +725     
==========================================
+ Hits         4157     5343    +1186     
+ Misses       7104     6626     -478     
- Partials      315      332      +17     

see 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CH3CHO CH3CHO merged commit 5536502 into alibaba:main Mar 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure OpenAI api 端点设置 failover 配置的话健康检查会报 401,不开的话则正常访问
3 participants