-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add redis init status log #1867
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1867 +/- ##
==========================================
+ Coverage 35.91% 43.39% +7.48%
==========================================
Files 69 76 +7
Lines 11576 12301 +725
==========================================
+ Hits 4157 5338 +1181
+ Misses 7104 6629 -475
- Partials 315 334 +19 🚀 New features to boost your workflow:
|
if rp.client.Ready() { | ||
rp.log.Info("redis init successfully") | ||
} else { | ||
rp.log.Error("redis init failed, will try later") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果现在没有重试逻辑的话,建议把“will try later”删掉。
另外,是不是把 err 也打出来更好?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个error会传到parseConfig阶段,在parseConfig阶段会打印的。如果仅仅是redis初始化没成功,这里不会返回error的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ai-cache 以及 ai-token-ratelimit 增加 redis init 相关日志