Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redis init status log #1867

Merged
merged 3 commits into from
Mar 10, 2025
Merged

add redis init status log #1867

merged 3 commits into from
Mar 10, 2025

Conversation

rinfx
Copy link
Collaborator

@rinfx rinfx commented Mar 10, 2025

ai-cache 以及 ai-token-ratelimit 增加 redis init 相关日志

@rinfx rinfx requested review from johnlanni and CH3CHO as code owners March 10, 2025 02:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.39%. Comparing base (ef31e09) to head (c326ebb).
Report is 339 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
+ Coverage   35.91%   43.39%   +7.48%     
==========================================
  Files          69       76       +7     
  Lines       11576    12301     +725     
==========================================
+ Hits         4157     5338    +1181     
+ Misses       7104     6629     -475     
- Partials      315      334      +19     

see 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if rp.client.Ready() {
rp.log.Info("redis init successfully")
} else {
rp.log.Error("redis init failed, will try later")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果现在没有重试逻辑的话,建议把“will try later”删掉。

另外,是不是把 err 也打出来更好?

Copy link
Collaborator Author

@rinfx rinfx Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个error会传到parseConfig阶段,在parseConfig阶段会打印的。如果仅仅是redis初始化没成功,这里不会返回error的

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rinfx rinfx merged commit 9e2df8f into alibaba:main Mar 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants