Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support files and batches APIs provided by Azure OpenAI #1904

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Mar 16, 2025

Ⅰ. Describe what this PR did

Support files and batches APIs provided by Azure OpenAI in OpenAI protocol:

  • /v1/files
  • /v1/files/{file_id}
  • /v1/files/{file_id}/content
  • /v1/batches
  • /v1/batches/{batch_id}
  • /v1/batches/{batch_id}/cancel

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Depends on #1886

@CH3CHO CH3CHO requested a review from johnlanni March 16, 2025 04:52
@CH3CHO CH3CHO requested review from cr7258 and rinfx as code owners March 16, 2025 04:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.41%. Comparing base (ef31e09) to head (1d544fb).
Report is 350 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
+ Coverage   35.91%   43.41%   +7.50%     
==========================================
  Files          69       76       +7     
  Lines       11576    12301     +725     
==========================================
+ Hits         4157     5340    +1183     
+ Misses       7104     6628     -476     
- Partials      315      333      +18     

see 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 5de7c2a into alibaba:main Mar 17, 2025
12 checks passed
@CH3CHO CH3CHO deleted the feat/azure-files-batches-apis branch March 17, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants