feat: add buffer_limit functions #1922
Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
==========================================
+ Coverage 35.91% 43.66% +7.75%
==========================================
Files 69 78 +9
Lines 11576 12479 +903
==========================================
+ Hits 4157 5449 +1292
+ Misses 7104 6687 -417
- Partials 315 343 +28 🚀 New features to boost your workflow:
|
| fn set_request_body_buffer_limit(&self, limit: u32) { | ||
| self.log() | ||
| .infof(format_args!("SetRequestBodyBufferLimit:{}", limit)); | ||
| internal::set_property( | ||
| vec!["set_decoder_buffer_limit"], | ||
| Some(limit.to_string().as_bytes()), | ||
| ); | ||
| } | ||
|
|
||
| fn set_response_body_buffer_limit(&self, limit: u32) { | ||
| self.log() | ||
| .infof(format_args!("SetResponseBodyBufferLimit:{}", limit)); | ||
| internal::set_property( | ||
| vec!["set_encoder_buffer_limit"], | ||
| Some(limit.to_string().as_bytes()), | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
set_decoder_buffer_limit 和 set_encoder_buffer_limit是底层支持的标准参数么？ @johnlanni 帮忙确认下。
另外internal::set_property建议修改为self.set_property
There was a problem hiding this comment.
| if self.http_content.borrow().not_read_response_body() { | ||
| return DataAction::Continue; | ||
| } |
There was a problem hiding this comment.
两个 not_read_开头函数的使用场景是什么？<not_read_response_body返回true>和<cache_response_body 返回 false, on_http_response_body中不做处理> 的差异是什么
There was a problem hiding this comment.
在header阶段判断不需要read body即可交由上游处理的情况。
这两个 not_read_ 函数参考自go插件https://github.com/higress-group/higress/blob/main/plugins/wasm-go/pkg/wrapper/plugin_wrapper.go#L246-L248
There was a problem hiding this comment.
可以，名字也按照go的统一成 need_response_body need_request_body 吧
| let binding = self.rule_matcher.borrow(); | ||
| let config = match binding.get_match_config() { | ||
| None => { | ||
| self.not_read_request_body(); |
There was a problem hiding this comment.
重新修改了函数名称，我们应该对应go插件中的DontReadRequestBody和DontReadResponseBody方法
https://github.com/higress-group/higress/blob/main/plugins/wasm-go/pkg/wrapper/plugin_wrapper.go#L215-L221
needRequestBody是CommonHttpCtx的属性并不对外暴露
https://github.com/higress-group/higress/blob/main/plugins/wasm-go/pkg/wrapper/plugin_wrapper.go#L179
最终函数名称按照go的命名为dont_read_request_body和dont_read_response_body
There was a problem hiding this comment.
DontReadRequestBody 和 DontReadResponseBody是set方法，你的是get方法，用在这里不太合适，就像128行这执行一个get方法是没用的
There was a problem hiding this comment.
按照go插件实现有问题，在wrapper中只有PluginHttpWrapper可以设置属性，用户实现的是 trait HttpContextWrapper导致无法处理 PluginHttpWrapper的数据，不能动态修改，是否先不实现read_body相关方法
There was a problem hiding this comment.
rust因为语言的一些限制导致没法和go的做成一样的，这个pr可以只修改 buffer_limit部分，read_body可以等想好怎么做再开个pr
There was a problem hiding this comment.
好的，已经将相关代码删除，请检查一下
Fengxq2014
changed the title
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews