Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mcp server config map #1969

Merged
merged 2 commits into from
Mar 27, 2025
Merged

fix: mcp server config map #1969

merged 2 commits into from
Mar 27, 2025

Conversation

Jing-ze
Copy link
Collaborator

@Jing-ze Jing-ze commented Mar 27, 2025

Ⅰ. Describe what this PR did

fix mcp server config map

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Jing-ze Jing-ze marked this pull request as ready for review March 27, 2025 09:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (ef31e09) to head (5f9b184).
Report is 393 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/kube/configmap/mcp_server.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1969      +/-   ##
==========================================
+ Coverage   35.91%   43.65%   +7.74%     
==========================================
  Files          69       79      +10     
  Lines       11576    12728    +1152     
==========================================
+ Hits         4157     5557    +1400     
+ Misses       7104     6824     -280     
- Partials      315      347      +32     
Files with missing lines Coverage Δ
pkg/ingress/kube/configmap/mcp_server.go 42.85% <0.00%> (ø)

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johnlanni johnlanni merged commit 83f69a0 into alibaba:main Mar 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants