Skip to content

Restructure to use ember-cli-deploy-plugin #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alisdair opened this issue Aug 9, 2015 · 3 comments
Open

Restructure to use ember-cli-deploy-plugin #1

alisdair opened this issue Aug 9, 2015 · 3 comments

Comments

@alisdair
Copy link
Owner

alisdair commented Aug 9, 2015

See this PR on ember-cli-deploy

@achambers
Copy link

Hi @alisdair. Aaron from the ember-cli-deploy core team here. Just had a look at the goal of your plugin and this type of functionality has changed quite a bit from v0.4.x of ember-cli-deploy.

ember-cli-deploy 0.5.0 uses a pipeline architecture where plugins can hook in to one or more of the deploy pipeline hooks. There is an existing plugin called ember-cli-deploy-revision-key whose job is to generate the revision key that will be used for pushing a file to some sort of store, eg Redis.

This plugin uses the ideas of key generators. Currently the only key generator implemented is a file hash generator that uses the fingerprint of the index.html file. However, a git-sha/git-tag generator is a perfect use case for another generator.

Can I put it out there that you contribute your ideas for the git tag functionality to the ember-cli-deploy-revision-key repo instead of maintaining a separate repo that does the same thing?

Give me a shout if you have any questions or want some background on the deploy pipeline, plugins etc etc.

Great work mate and thanks for contributing to the ember deploy eco system. 👍

@alisdair
Copy link
Owner Author

Sounds good! Will look into that and submit a PR.

@achambers
Copy link

Champion ;)
On Mon, 10 Aug 2015 at 12:46 Alisdair McDiarmid [email protected]
wrote:

Sounds good! Will look into that and submit a PR.


Reply to this email directly or view it on GitHub
#1 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants