This repository was archived by the owner on Apr 4, 2018. It is now read-only.
[#130188061] Add ability to disallow pull requests from forks #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrytk
changed the title
henrytk
force-pushed
the
disallow_forks
branch
3 times, most recently
from
1875238 to
2531eb2
Compare
This makes it consistent with the rest of the methods in this class, and makes it easier to add additional arguments.
alext
force-pushed
the
disallow_forks
branch
from
cdbac6c to
2fc0356
Compare
In some cases you may want to only allow pull requests from within your own team. This is useful in scenarios where you cannot have untrusted code being pulled into your Concourse pipeline. This commit adds the ability to optionally set a `disallow_forks` configuration, which if set to true will only consider pull requests valid if they are raised from within the same repository. The value of this configuration is false by default and does not interfere with the normal behaviour of the resource.
henrytk
force-pushed
the
disallow_forks
branch
from
2fc0356 to
9fb184e
Compare
henrytk
changed the title
henrytk
added a commit
to alphagov/paas-release-ci
that referenced
this pull request
Nov 23, 2016
We can remove this commit once our pull request[1] has been accepted and the new Docker image has been built from `gds_master` [1] alphagov/paas-pullrequest-resource#1
henrytk
changed the title
alext
pushed a commit
to alphagov/paas-release-ci
that referenced
this pull request
Nov 23, 2016
We can remove this commit once our pull request[1] has been accepted and the new Docker image has been built from `gds_master` [1] alphagov/paas-pullrequest-resource#1
henrytk
added a commit
to alphagov/paas-release-ci
that referenced
this pull request
Nov 23, 2016
We can remove this commit once our pull request[1] has been accepted and the new Docker image has been built from `gds_master` [1] alphagov/paas-pullrequest-resource#1
alext
pushed a commit
to alphagov/paas-release-ci
that referenced
this pull request
Nov 23, 2016
We can remove this commit once our pull request[1] has been accepted and the new Docker image has been built from `gds_master` [1] alphagov/paas-pullrequest-resource#1
alext
pushed a commit
to alphagov/paas-release-ci
that referenced
this pull request
Nov 23, 2016
We can remove this commit once our pull request[1] has been accepted and the new Docker image has been built from `gds_master` [1] alphagov/paas-pullrequest-resource#1
alext
pushed a commit
to alphagov/paas-release-ci
that referenced
this pull request
Nov 23, 2016
We can remove this commit once our pull request[1] has been accepted and the new Docker image has been built from `gds_master` [1] alphagov/paas-pullrequest-resource#1
alext
pushed a commit
to alphagov/paas-release-ci
that referenced
this pull request
Nov 23, 2016
We can remove this commit once our pull request[1] has been accepted and the new Docker image has been built from `gds_master` [1] alphagov/paas-pullrequest-resource#1
alext
pushed a commit
to alphagov/paas-release-ci
that referenced
this pull request
Nov 23, 2016
We can remove this commit once our pull request[1] has been accepted and the new Docker image has been built from `gds_master` [1] alphagov/paas-pullrequest-resource#1
|
@jtarchie Thanks for the feedback, that all sounds good. We intended to run this internally for a little bit to verify the behaviour before raising a PR against your repo (that's what this PR is for). |
alext
changed the title
|
This looks fine. I added a minor tweak to get tests passing in my environment. I'll merge. |
|
@benhyland What was the issue you were hitting? It would have been good to explain that in the commit message. |
|
Sourcing the common.sh file ensures that the default TMPDIR value is set in case it is not specified by the environment. Without it mktemp can fail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#130188061 - Migrate existing AWS-RDS bosh release builds to use pullrequest-resource based builds
In some cases you may want to only allow pull requests from within your own team. This is useful in scenarios where you cannot have untrusted code being pulled into your Concourse pipeline.
This commit adds the ability to optionally set a
disallow_forksconfiguration, which if set to true will only consider pull requests valid if they are raised from within the same repository. The value of this configuration is false by default and does not interfere with the normal behaviour of the resource.How to review
Review as part of alphagov/paas-release-ci#1
Also:
bundle install && bundle exec rspecWho
Anyone but me or @alext