-
Notifications
You must be signed in to change notification settings - Fork 448
Update to use aws/aws-sdk-js#1123 explicit webpack support. #140
Conversation
- Update README.md to use new aws-sdk webpack support. - Simplify NPM install by making the dependencies direct. This is apparently OK for aws-sdk to do, so we may as well make it nicer for the end-user. - Remove old grunt build and deps.
So should we hold off on the merge for now or is it ok? |
Sorry, I was still a bit unclear! Just got a reply for the import issue, but that is just for the suggested usage doc update. |
@itrestian See edits to description, in particular this will require updating |
@itrestian Hi, any reason it isn't being merged ? |
No reason! We will merge it but I need to do the things Simon mentioned: build aws-cognito-sdk.min.js from aws-sdk 2.6.0. And check if everything works correctly. |
Great Thanks 👍 |
Can you confirm that we can use, modify, copy, and redistribute this PR? Thanks! |
You can use, modify, copy, and redistribute this PR. |
@itrestian Ping? |
Yes, just started working on this :). |
Hi Simon, Everything works great for me. I updated aws-cognito-sdk.min.js from aws-sdk v2.6.4 and it seems to be working. I will merge ASAP! Thanks a lot! |
Merged and updated dist files. |
aws/aws-sdk-js#1123 just merged and published version 2.6.0 adding native webpack support, which means we can simplify our suggested webpack setup.
Update README.md to use new aws-sdk webpack support.
Simplify NPM install by making the dependencies direct rather than peer dependencies.
This is apparently OK for aws-sdk to do, so we should be able to may as well make it nicer
for the end-user.
Remove old grunt build and deps.
The webpack setup docs could later be updated to talk about optimising bundle size, essentially, never
require('aws-sdk')
/import 'aws-sdk'
, always useaws-sdk/global
oraws-sdk/clients/SERVICE
:should instead be:
But previous usage would still work as is so long as you update the
aws-sdk
you build your bundle from so the dist update for this should also update theaws-cognito-sdk.min.js
build to be from 2.6.0