This repository was archived by the owner on Feb 7, 2023. It is now read-only.
Fixes for issues - #94 #95 #92 and made path to multiselect.tmpl.html relative #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 22, 2016 22:52
…o the model value amitava82#94 Possible fix for issue - Show only one property but select complete object amitava82#92 File changed - multiselect.js Changes made - Added a new function - getItemLabel(items,model) Calling the above function in function getHeaderText()
…o the string modal value amitava82#95 Possible fix for issue - Show only one property but select complete object amitava82#92 File changed - multiselect.js Changes made - Calling the function getItemLabel(items,model) in function getHeaderText()
…file multiselect.js.
Changes made --
// getting the path of the multiselect.js file
var scripts = document.getElementsByTagName("script")
var currentScriptPath = scripts[scripts.length-1].src;
Used the currentScriptPath ass below -
templateUrl: function (element, attr) {
// multiselect.tmpl.html path relative to multiselect.js
return attr.templateUrl || currentScriptPath.substring(0, currentScriptPath.lastIndexOf('/') + 1)
+ 'multiselect.tmpl.html';
},
Solution from -- http://stackoverflow.com/a/21103831/1298824
Plnkr example -- http://plnkr.co/edit/kQ8Uz6uztzBeo8DvlpO9?p=preview
NithinBiliya
changed the title
|
Thanks! Can you update the readme, github pages with new changes? |
|
Looks like last few pulls were into master branch. gh-pages branch is not in sync with the master. Its missing few updates. |
added 20 commits
November 28, 2016 13:32
…its usage. Usage - add option 'hover="true"' in the am-multiselect tag. This will show the button header text as the hover text when you hover over the button. This is useful when the button length is fixed and the header text overfows the button size. Plnkr demo link - http://plnkr.co/edit/yKy9kNF9dXsnHXzHSTJB?p=preview
…eed to uncheck all items and clear searchText.label Added code to uncheck and clear the label value in the modelValue watch.
need to uncheck from the entire list of items. If user filers with ine text and selects item A. Next time user fileters and selects item B (item A now not in the filtered set). The item A will not get unchecked
… instead of true to setModelValue. Since different values geeting set when single and multiple
…defined, if it is not assigned any value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File changed - multiselect.js
Fix for issues -
Changes made -
Added a new function - getItemLabel(items,model)
Calling the above function in function getHeaderText()
get the currentScriptPath
// getting the path of the multiselect.js file
var scripts = document.getElementsByTagName("script")
var currentScriptPath = scripts[scripts.length-1].src;
Used the currentScriptPath as below -
templateUrl: function (element, attr) {
// multiselect.tmpl.html path relative to multiselect.js
return attr.templateUrl || currentScriptPath.substring(0, currentScriptPath.lastIndexOf('/') + 1)
+ 'multiselect.tmpl.html';
},
Plnkr link after fixes - link3