Skip to content

add _lock and improve CPU usage calc formula #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: add-cancellation-and-resource-monitoring-to-imonitor
Choose a base branch
from
Open

add _lock and improve CPU usage calc formula #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96cb24d
add _lock and improve CPU usage calc formula
LittleLittleCloud Jan 9, 2023
ae3ff87
sample CPU && Memory usage while monitor pausing.
LittleLittleCloud Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,14 +273,13 @@ void handler(object o, EventArgs e)
performanceMonitor.Start();
logger.Trace($"trial setting - {JsonSerializer.Serialize(trialSettings)}");
var trialResult = await trialTask;

performanceMonitor.Pause();
var peakCpu = performanceMonitor?.GetPeakCpuUsage();
var peakMemoryInMB = performanceMonitor?.GetPeakMemoryUsageInMegaByte();
trialResult.PeakCpu = peakCpu;
trialResult.PeakMemoryInMegaByte = peakMemoryInMB;
trialResult.TrialSettings.EndedAtUtc = DateTime.UtcNow;

performanceMonitor.Pause();
monitor?.ReportCompletedTrial(trialResult);
tuner.Update(trialResult);
trialResultManager?.AddOrUpdateTrialResult(trialResult);
Expand Down
54 changes: 31 additions & 23 deletions src/Microsoft.ML.AutoML/AutoMLExperiment/IPerformanceMonitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ public class DefaultPerformanceMonitor : IPerformanceMonitor
private double? _peakMemoryUsage;
private readonly int _checkIntervalInMilliseconds;
private TimeSpan _totalCpuProcessorTime;
private DateTime _previousSamplingUtcTime;
private static readonly object _lock = new object();


public DefaultPerformanceMonitor(AutoMLExperiment.AutoMLExperimentSettings settings, IChannel logger, int checkIntervalInMilliseconds)
{
Expand Down Expand Up @@ -79,12 +82,11 @@ public void Start()
{
_timer = new Timer(_checkIntervalInMilliseconds);
_totalCpuProcessorTime = Process.GetCurrentProcess().TotalProcessorTime;
_previousSamplingUtcTime = DateTime.UtcNow;
_timer.Elapsed += OnCheckCpuAndMemoryUsage;
_timer.AutoReset = true;
_logger?.Trace($"{typeof(DefaultPerformanceMonitor)} has been started");
}

// trigger the PerformanceMetricsUpdated event and (re)start the timer
_timer.Enabled = false;
SampleCpuAndMemoryUsage();
_timer.Enabled = true;
Expand All @@ -93,6 +95,7 @@ public void Start()
public void Pause()
{
_timer.Enabled = false;
SampleCpuAndMemoryUsage();
}

public void Stop()
Expand All @@ -119,28 +122,33 @@ private void SampleCpuAndMemoryUsage()
// the % of CPU usage by current process is simply currentCpuProcessorTime / total CPU time.
using (var process = Process.GetCurrentProcess())
{
var currentCpuProcessorTime = Process.GetCurrentProcess().TotalProcessorTime;
var elapseCpuProcessorTime = currentCpuProcessorTime - _totalCpuProcessorTime;
var cpuUsedMs = elapseCpuProcessorTime.TotalMilliseconds;
var cpuUsageInTotal = cpuUsedMs / (Environment.ProcessorCount * _checkIntervalInMilliseconds);
_totalCpuProcessorTime = currentCpuProcessorTime;
_peakCpuUsage = Math.Max(cpuUsageInTotal, _peakCpuUsage ?? 0);

// calculate Memory Usage in MB
var memoryUsage = process.PrivateMemorySize64 * 1.0 / (1024 * 1024);
_peakMemoryUsage = Math.Max(memoryUsage, _peakMemoryUsage ?? 0);

var metrics = new TrialPerformanceMetrics()
lock (_lock)
{
CpuUsage = cpuUsageInTotal,
MemoryUsage = memoryUsage,
PeakCpuUsage = _peakCpuUsage,
PeakMemoryUsage = _peakMemoryUsage
};

_logger?.Trace($"current CPU: {cpuUsageInTotal}, current Memory(mb): {memoryUsage}");

PerformanceMetricsUpdated?.Invoke(this, metrics);
var currentUtc = DateTime.UtcNow;
var currentCpuProcessorTime = process.TotalProcessorTime;
var elapseCpuProcessorTime = currentCpuProcessorTime - _totalCpuProcessorTime;
var cpuUsedMs = elapseCpuProcessorTime.TotalMilliseconds;
var cpuUsageInTotal = cpuUsedMs / (Environment.ProcessorCount * (currentUtc - _previousSamplingUtcTime).TotalMilliseconds);
_totalCpuProcessorTime = currentCpuProcessorTime;
_previousSamplingUtcTime = currentUtc;
_peakCpuUsage = Math.Max(cpuUsageInTotal, _peakCpuUsage ?? 0);

// calculate Memory Usage in MB
var memoryUsage = process.PrivateMemorySize64 * 1.0 / (1024 * 1024);
_peakMemoryUsage = Math.Max(memoryUsage, _peakMemoryUsage ?? 0);

var metrics = new TrialPerformanceMetrics()
{
CpuUsage = cpuUsageInTotal,
MemoryUsage = memoryUsage,
PeakCpuUsage = _peakCpuUsage,
PeakMemoryUsage = _peakMemoryUsage
};

_logger?.Trace($"current CPU: {cpuUsageInTotal}, current Memory(mb): {memoryUsage}");

PerformanceMetricsUpdated?.Invoke(this, metrics);
}
}
}

Expand Down