Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

First commit for DonutTracker app, a sample for the MAD Skills #910

Merged
merged 8 commits into from
Oct 14, 2020

Conversation

chethaase
Copy link
Contributor

Navigation series

This app consists of a list of items (donuts) in a RecyclerView
and a dialog used to enter or edit information about those items.
The sample is mainly useful in conjunction with the MAD Skills series
of articles and videos that use the sample; there are other samples
in this repo that are intended for more general-purpose exmaples
of the Navigation Component.

Navigation series

This app consists of a list of items (donuts) in a RecyclerView
and a dialog used to enter or edit information about those items.
The sample is mainly useful in conjunction with the MAD Skills series
of articles and videos that use the sample; there are other samples
in this repo that are intended for more general-purpose exmaples
of the Navigation Component.
Copy link
Contributor

@florina-muntenescu florina-muntenescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits
run and address lint issues

Navigation series

This app consists of a list of items (donuts) in a RecyclerView
and a dialog used to enter or edit information about those items.
The sample is mainly useful in conjunction with the MAD Skills series
of articles and videos that use the sample; there are other samples
in this repo that are intended for more general-purpose exmaples
of the Navigation Component.
@chethaase
Copy link
Contributor Author

Hey - I made the changes from the review, mostly fixed through running lint, as you said

Copy link
Contributor

@florina-muntenescu florina-muntenescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits. feel free to merge once addressed

@chethaase chethaase merged commit 2c19434 into main Oct 14, 2020
@chethaase chethaase deleted the NavMadSkillsCreation branch October 14, 2020 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants