This repository was archived by the owner on Jan 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
First commit for DonutTracker app, a sample for the MAD Skills #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigation series This app consists of a list of items (donuts) in a RecyclerView and a dialog used to enter or edit information about those items. The sample is mainly useful in conjunction with the MAD Skills series of articles and videos that use the sample; there are other samples in this repo that are intended for more general-purpose exmaples of the Navigation Component.
florina-muntenescu
suggested changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly nits
run and address lint issues
...igationSample/app/src/main/java/com/android/samples/donuttracker/DonutEntryDialogFragment.kt
Outdated
Show resolved
Hide resolved
...igationSample/app/src/main/java/com/android/samples/donuttracker/DonutEntryDialogFragment.kt
Outdated
Show resolved
Hide resolved
...igationSample/app/src/main/java/com/android/samples/donuttracker/DonutEntryDialogFragment.kt
Outdated
Show resolved
Hide resolved
...lsNavigationSample/app/src/main/java/com/android/samples/donuttracker/DonutEntryViewModel.kt
Outdated
Show resolved
Hide resolved
MADSkillsNavigationSample/app/src/main/java/com/android/samples/donuttracker/DonutList.kt
Show resolved
Hide resolved
MADSkillsNavigationSample/app/src/main/res/layout/donut_item.xml
Outdated
Show resolved
Hide resolved
MADSkillsNavigationSample/app/src/main/res/layout/donut_item.xml
Outdated
Show resolved
Hide resolved
Navigation series This app consists of a list of items (donuts) in a RecyclerView and a dialog used to enter or edit information about those items. The sample is mainly useful in conjunction with the MAD Skills series of articles and videos that use the sample; there are other samples in this repo that are intended for more general-purpose exmaples of the Navigation Component.
…e-components-samples into NavMadSkillsCreation
…e-components-samples into NavMadSkillsCreation
Hey - I made the changes from the review, mostly fixed through running lint, as you said |
MADSkillsNavigationSample/app/src/main/java/com/android/samples/donuttracker/DonutList.kt
Outdated
Show resolved
Hide resolved
florina-muntenescu
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits. feel free to merge once addressed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation series
This app consists of a list of items (donuts) in a RecyclerView
and a dialog used to enter or edit information about those items.
The sample is mainly useful in conjunction with the MAD Skills series
of articles and videos that use the sample; there are other samples
in this repo that are intended for more general-purpose exmaples
of the Navigation Component.