Demo page looks ugly with BS3, needs update to new styling

[pkozlowski-opensource]

No description provided.

[lazychino]

Hello @pkozlowski-opensource, you have something specific that you don't like or like want changed?

And I was thinking about modding a little the timepicker look on BS3

I thinks it looks odd, should I work as part of this issues or as separate one?

[pkozlowski-opensource]

@lazychino I've opened this issue for the overall design of the demo page itself. We can do a time-picker specific fix in #1285. I'm not sure how it should look for BS3 as I didn't look at the existing solutions.

[thienedits]

What about adding a sidenav? Bootstrap 3.0 has a really wide layout. I can try to add a sidenav and fix the look of the tabs.

[gmaliar]

Hi guys, after patching the modal ui.bootstrap today to work with bootstrap 3 I looked at what's missing in the milestones to release it, I saw the demo page was a milestone postponing release so I forked it and did some work on it.
I'm not css savvy so I didn't completely styled the colors but that's pretty easy as well so for the time being I fixed the markup to fit Bootstrap3.

#1309

[thienedits]

I almost have something I can make a pull request with. I just need to try and add this angular affix plugin for the sidebar.

https://github.com/mgcrea/angular-bootstrap-affix

[thienedits]

I am getting this weird git commit error:

git commit -m "update ui"
INVALID COMMIT MSG: does not match "type scope: subject" ! was: "update ui"
Note: scope must be only letters.

[gmaliar]

A proper commit message in angular-ui/bootstrap is 

git commit -m “chore(demopage): Updated UI”
git commit -m “bugfix(carousel): Change kittens to puppies”
etc. etc.

it’s the type (chore/bugfix etc.) the scope of the work (carousel/accordion etc.) and the message.

-- 
Guy Maliar
Sent with Airmail

On November 27, 2013 at 10:41:03 AM, thienedits ([email protected]) wrote:

I am getting this weird git commit error:

git commit -m "update ui"

INVALID COMMIT MSG: does not match "type scope: subject" ! was: "update ui"
Note: scope must be only letters.

—
Reply to this email directly or view it on GitHub.

[thienedits]

awesome thanks that worked

[kristianmandrup]

So how does it look now? ;)

[Mitdasein]

It looks like i wasted two hours trying to get Dropdown Toggle to work, is what it looks like.

[thienedits]

I upload some PNG screenshots. Download the files and view them at "Actual/Full Size".

https://drive.google.com/folderview?id=0B0qdt7xwL6A8cldMZS1odjhHR0k&usp=sharing

[pkozlowski-opensource]

Fixes are in the bootstrap3 branch now!

[thienedits]

nice 👍