Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Unable to generate new builds #1458

Closed
mvhecke opened this issue Dec 24, 2013 · 3 comments
Closed

Unable to generate new builds #1458

mvhecke opened this issue Dec 24, 2013 · 3 comments

Comments

@mvhecke
Copy link
Contributor

mvhecke commented Dec 24, 2013

When trying to generate a build using the grunt build command, it executes without any noticeable errors. The builds that should include the templates however do not contain the templates. So I tried grunt test to see if anything is wrong and it does because it fails on 479 tests. At the moment I'm running Node v0.10.24, does anybody know if this causes the problem?

@chrisirhc
Copy link
Contributor

Looks like this is related to #253 . Run the grunt build doesn't run the html2js task.

@pkozlowski-opensource
Copy link
Member

@Gamemaniak As indicated in the documentation (https://github.com/angular-ui/bootstrap#build) you either need to either run grunt to build the whole project or run grunt html2js before running grunt build.

@chrisirhc we could run the html2js task in the build goal but it would mean running it twice.

I really not sure how to make this better with the current Grunt as - AFAIK - there is no way to require one task to be run before other tasks.

Closing for now, let's tackle this when anyone has an idea of a reasonable fix. I wonder why people assume grunt build to work as this is not a common Grunt convention and our documentation indicates that html2js needs to be run first....

@mvhecke
Copy link
Contributor Author

mvhecke commented Dec 25, 2013

Aah it's been a while since I've build a new version, I remember a few months back that this was the way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants