Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Javascript templates for Progressbar are missing #253

Closed
redaemn opened this issue Mar 20, 2013 · 4 comments
Closed

Javascript templates for Progressbar are missing #253

redaemn opened this issue Mar 20, 2013 · 4 comments

Comments

@redaemn
Copy link

redaemn commented Mar 20, 2013

that's all...

edit:
ok, found the problem... html2js task must be run by hand...
isn't it better if it was run automatically before every build?

@pkozlowski-opensource
Copy link
Member

@redaemn we could probably force templates compilation for each task but realized that it will run every time, even if I'm doing TDD in the test-watch mode.

I'm kind of divided here, it happened to me to forget to re-generate templates while doing TDD. At the same time I'm not so keen on adding additional processing to the test step as it really needs to run fast.

@angular-ui/bootstrap thoughts on this?

@ajoslin
Copy link
Contributor

ajoslin commented Mar 24, 2013

Testacular has an html2js preprocessor built in doesn't it? Could we try using that?

@pkozlowski-opensource
Copy link
Member

@ajoslin Andy, I had a look at the html2js at one point but then noticed that it generates only one AngularJS module for all the partials which is not what we do today (one template = AngularJS module). Not sure what are the consequences for the whole build, especially for the custom build.

But sure, if we could make it work for us it would be great!

@pkozlowski-opensource
Copy link
Member

Closing for now, we can always reopen when we've got precise idea of what we want to do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants