typeahead directive's properties can't be dynamic

[zzal]

Hi,

Since some options are set private within the link function of the typeahead directive, they are not binded.
For instance, if I set a property:

typeahead-editable="isAtLeastAdmin()"

or:

typeahead-editable="{{ isAtLeastAdmin() }}"

The changes in the result of the $scope.isAtLeastAdmin function are never passed to the directive.

So what I suggest is to not set theses options in private variables.
I can attempt what I'm trying if I change line 169 of src/typeahead/typeahead.js:

  if (originalScope.$eval(attrs.typeaheadEditable) !== false) {
    return inputValue;
  } else {

and use it like this: typeahead-editable="isAtLeastAdmin()"

Maybe I should make a pull request, or someone have an idea for a better implementation?

Thanks!

[pkozlowski-opensource]

@zzal yes, this is by design. The thing is that each "dynamic" property requires an additional watch so it needs to be well justified. We simply haven't had a use-case where someone wanted to have this editable property being dynamic.

I don't think we should make all the attributes "dynamic" systematically but rather move more and more logic to the typeahead controller so people can implement the desired logic.

@chrisirhc I guess this is one more use-case for the typeahead refactoring. Are you still working on this topic? I should have time to look into it in the coming days.

[chrisirhc]

Yep, I'll be doing another pass in the next few days, by Friday, if that's okay.

[zzal]

Thanks, it will be much appreciated!

[pkozlowski-opensource]

OK, let's tackle this one as part of #888 then!

[larshjohannesson]

Hello,

I have a use case for this:
We are developing an invoice system where one input field is the client's name which is normally populated using typeahead and a search for existing customers. It is however desirable to be able to add a new customer on the fly using the same form and then I want to turn off typeahead-editable="false"