add tooltip-html-unsafe directive

[lanterndev]

See discussion in #154 and #202.

[joshdmiller]

Thanks for opening this, @Skivvies. There is an outstanding tooltip pull request. As soon as that goes through (should be tomorrow-ish), this is what I'll work on.

[mlunoe]

ng-show does not work with your tooltip-html-unsafe.
E.g. tooltip-html-unsafe='Hello'

[joshdmiller]

@mlunoe What do you mean?

If you mean you can't pass ngShow into the tooltip as HTML, then you're right. The contents of the HTML are not compiled, so no AngularJS directives will work. This is meant for adding newlines with <br /> or adding bold or italic fonts, etc. I'm not sure I see the value in adding complex markup to a tooltip; if this is your issue, can you elaborate on your use case?

If you mean that <a tooltip-html-unsafe="blah" ng-show="myProp">Hello</a> doesn't work, can you post a Plunker?

[mlunoe]

Hi Josh.

Sorry, it was a bit late for me when I commented and when you wrote me I
realised, that I was using a tooltip for something completely outside of
its purpose!

if you are interested I wanted to show my stackoverflow score in the
tooltip, here's the code:

<a 
  class="stack-info" href="http://stackoverflow.com/users/1008519/mlunoe"
  target="_blank" tooltip-placement="bottom" tooltip-html-unsafe=' <span
class="stack-info" ng-show="stackOverflow.score > 0">
{{stackOverflow.score}} </span> <span class="gold badgecount"
ng-show="stackOverflow.badge_counts.gold > 0"> <i class="icon-circle"></i>
{{stackOverflow.badge_counts.gold}} </span> <span class="silver badgecount"
ng-show="stackOverflow.badge_counts.silver > 0"> <i
class="icon-circle"></i> {{stackOverflow.badge_counts.silver}} </span>
<span class="bronze badgecount" ng-show="stackOverflow.badge_counts.bronze
> 0"> <i class="icon-circle"></i> {{stackOverflow.badge_counts.bronze}}
</span>'>
  <i class="icon-stack-overflow icon-large"></i>
</a>

And it works awesome :)

The idea was to only show when there was actually any badges (that is e.g.
not the case with gold badges for me)

So I am sorry about the comment as it was beyond the use of the tooltip
function. However, I started thinking and I realised, that somebody might
need it for, e.g. personalising tooltips or just showing different tooltips
based on the state. A basic solution would be to show the contents of a
variable, but if you wanted to show some tooltips for a new user logging in
to the application for the first time and something slightly the same under
some other conditions you need to create a new element for each.

Again, this was thoughts, however I think it could be kinda cool to explore
the uses of such a functionality :)

Best regards,

Michael

On Tue, Apr 2, 2013 at 1:31 AM, Josh D Miller [email protected]:

@mlunoe https://github.com/mlunoe What do you mean?

If you mean you can't pass ngShow into the tooltip as HTML, then you're
right. The contents of the HTML are not compiled, so no AngularJS
directives will work. This is meant for adding newlines with
or
adding bold or italic fonts, etc. I'm not sure I see the value in adding
complex markup to a tooltip; if this is your issue, can you elaborate on
your use case?

If you mean that Hellodoesn't work, can you post a Plunker?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/246#issuecomment-15743682
.

[joshdmiller]

Yeah, it's not really meant to show content that complicated. We've considered allowing passing in a template (e.g. tooltip-template="'myfile.tpl.html'") that you can use to overwrite the default and that may be a better way to solve for a case like yours. But out of the box, I think it's asking too much out an HTML attribute.

If you want to explore using a template, open an issue and we can move the discussion there.

[jhiemer]

Hi guys,
short question, after the test passed, when is are these features going into the the main source base?