This repository was archived by the owner on May 29, 2019. It is now read-only.
Make $modalinstance.close animation time configurable #2536
Labels
Milestone
Comments
|
Will be fixed via #2724 |
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Oct 20, 2014
- Fix scope.$apply call not working previously because scope was already destroyed. Use $rootScope instead. - Move $destroy call nearer to the dom removal. - Remove fallback timer (emulateTime param) Fixes angular-ui#2585 Fixes angular-ui#2674 Fixes angular-ui#2536 Fixes angular-ui#2790
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Mar 19, 2015
- Fix scope.$apply call not working previously because scope was already destroyed. Use $rootScope instead. - Move $destroy call nearer to the dom removal. - Remove fallback timer (emulateTime param) Fixes angular-ui#2585 Fixes angular-ui#2674 Fixes angular-ui#2536 Fixes angular-ui#2790 Fixes angular-ui#3182
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Mar 23, 2015
- Fix scope.$apply call not working previously because scope was already destroyed. Use $rootScope instead. - Move $destroy call nearer to the dom removal. - Remove fallback timer (emulateTime param) Fixes angular-ui#2585 Fixes angular-ui#2674 Fixes angular-ui#2536 Fixes angular-ui#2790 Fixes angular-ui#3182 Closes angular-ui#2724
ayakovlevgh
pushed a commit
to ayakovlevgh/bootstrap
that referenced
this issue
Mar 24, 2015
- Fix scope.$apply call not working previously because scope was already destroyed. Use $rootScope instead. - Move $destroy call nearer to the dom removal. - Remove fallback timer (emulateTime param) Fixes angular-ui#2585 Fixes angular-ui#2674 Fixes angular-ui#2536 Fixes angular-ui#2790 Fixes angular-ui#3182 Closes angular-ui#2724
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
on line 1510 in ui-bootstrap-tpls.js of the bower package This line should be configurable.
removeAfterAnimate(modalWindow.modalDomEl, modalWindow.modalScope, 300, checkRemoveBackdrop);
Currently I have overwritten the 300 value to 0. That way I could completely disable the animations. However, it would be nice if in a next release, that value would be configurable so I don't lose my change with updates.
The text was updated successfully, but these errors were encountered: