Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

After 1.0, Bootstrap menus don't really work #5186

Closed
nickdnk opened this issue Jan 9, 2016 · 4 comments
Closed

After 1.0, Bootstrap menus don't really work #5186

nickdnk opened this issue Jan 9, 2016 · 4 comments
Assignees
@icfantv
Labels
component: dropdown type: doc

Comments

@nickdnk
Copy link

nickdnk commented Jan 9, 2016

Hello

I just tried upgrading to 1.0.0, but now my Bootstrap-built menus don't work properly. Please see attached screenshot. This issue goes away if I go back to 0.14.3
screen shot 2016-01-09 at 03 03 40
The menu should be collapsed and selectable by clicking the (in this case) "Management" button.

Angular version is 1.4.8. Depicted menu built like such:
`

` No errors logged to console.
@nickdnk
Copy link
Author

nickdnk commented Jan 9, 2016

Seems I was using class="uib-dropdown-menu" where I should have used just uib-dropdown-menu. Now it works.

@nickdnk nickdnk closed this as completed Jan 9, 2016
@readme42
Copy link

Sorry for using a closed issue, but i can confirm:

class="uib-dropdown-menu"is working in 0.14.3 but not in 1.1.0

Could you add this to the Breaking Changes section in the Changelog? Using it as attribute works fine.

@icfantv
Copy link
Contributor

icfantv commented Jan 21, 2016

Sorry about this. We've had issues with the CHANGELOG generator in the past missing stuff, but I just noticed #4753 was missing the Breaking Change tag even though the PR #4975 had it. I will update the changelog to show this.

@icfantv icfantv reopened this Jan 21, 2016
@icfantv icfantv self-assigned this Jan 21, 2016
icfantv added a commit to icfantv/bootstrap that referenced this issue Jan 21, 2016
@icfantv
fix(doc): fix changelog for issue 5186
8eca12b 
* update changelog to indicate bug fix angular-ui#4753.
* update changelog to indicate PR angular-ui#4975.
* update changelog breaking changes to indicate change made.

Fixes angular-ui#5186
@icfantv icfantv mentioned this issue Jan 21, 2016
Closed
@readme42
Copy link

Never mind, thanks for the update!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@icfantv icfantv

Labels
component: dropdown type: doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(doc): fix changelog for issue 5186 icfantv/bootstrap
3 participants
@icfantv @readme42 @nickdnk