Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

tooltip and popover flicker before correctly positioned #5678

Closed
Rouche opened this issue Mar 22, 2016 · 11 comments
Closed

tooltip and popover flicker before correctly positioned #5678

Rouche opened this issue Mar 22, 2016 · 11 comments

Comments

@Rouche
Copy link
Contributor

Rouche commented Mar 22, 2016

Hello,
After updating from 1.1.2 to 1.2.5 i have this same bug happening : #4407

It seems to happen when using popover-template that is not yet in template cache.
The plunker does not have the exact same issue. The arrow disapear and ficker a bit less.
The link is on the right end and better seen in a popup window preview.
http://plnkr.co/edit/Ej1NfYa3Oj75ZUv0vFVB?p=preview

Angular: 1.5.0
UIBS: 1.2.5
Bootstrap: 3.3.6

Edit: plunk changed for a cached template. so both examples are there.

@Foxandxss
Copy link
Contributor

Will take a look, but the official angular team recommendation is to template cache all your templates before using it.

@Rouche
Copy link
Contributor Author

Rouche commented Mar 22, 2016

Yes in production we will. .

@icfantv
Copy link
Contributor

icfantv commented Mar 22, 2016

If you're doing it in production, you should also be doing it for development and test. Short of initial file download size (or heavenforbid a dynamic template provider by your server), I can't think any good reason not to cache the templates in advance. Modern build tools like webpack make doing this pretty painless.

@Rouche
Copy link
Contributor Author

Rouche commented Mar 22, 2016

I agree. For dev its just annoying not having a builtin eclipse plugin and need to run a --watch and refresh, etc. But thats another story :)

@RobJacobs
Copy link
Contributor

This has been discussed before and the conclusion was, if you don't have the popover/tooltip templates loaded in the templateCache, this is the side effect. See issue #4639

@Rouche
Copy link
Contributor Author

Rouche commented Mar 22, 2016

Ok i did not see this one. So its definatelly the reason.
Well i informed the QAs, so it should not be that bad now.

Closing.

@Rouche Rouche closed this as completed Mar 22, 2016
@icfantv
Copy link
Contributor

icfantv commented Mar 22, 2016

Hey @RobJacobs, I'm going to re-open this until we get a note in the docs about this.

@Rouche
Copy link
Contributor Author

Rouche commented Mar 22, 2016

Thanks for answers!

@Rouche
Copy link
Contributor Author

Rouche commented May 20, 2016

The problem you have seems to be with the button css or something.

Check this one with a simple div:
http://plnkr.co/edit/ewp6NzFIOe1cOKgwcpje?p=preview

On Fri, May 20, 2016 at 10:50 AM, Jeff [email protected] wrote:

@RobJacobs https://github.com/RobJacobs @icfantv
https://github.com/icfantv @Rouche https://github.com/Rouche I don't
think this is necessarily a templateCache issue, but I could be mistaken.
Even after sending the template to cache I have a flickering tooltip on a
right-floated button near the right-edge of the viewport.

I have verified that the template is chached by inspecting chromes's
chrome://cache and found the template in the list.

Plunkr http://plnkr.co/edit/eMulLM04mYtyr7yhAhl6?p=preview to
reproduce.

Help would be great.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5678 (comment)

@Jefftopia
Copy link

@Rouche Since it doesn't seem to be related to your issue, I opened a new ticket here.

In your example, the issue persists. Just remove the float: right from the button. When the div you added is at the right-edge, it also flickers as I described.

Also, we can't let the css be the scapegoat. It's pure bootstrap 3.3.6. UI-Bootstrap has to work with UI CSS, otherwise, what's the point of the library?

@wesleycho
Copy link
Contributor

Going to close as being tracked by #5918

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants