Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Allow minSearch to be 0 and open on down arrow #1142

Closed
wants to merge 1 commit into from
Closed

Allow minSearch to be 0 and open on down arrow #1142

wants to merge 1 commit into from

Conversation

cindoum
Copy link

@cindoum cindoum commented Oct 8, 2013

Fix minSearch to accept 0 as value and fix the underlying fonctions.

Fix minSearch to accept 0 as value and fix the underlying fonctions.
@pkozlowski-opensource
Copy link
Member

@cindoum I understand what you are trying to do but you are choosing a particular, arbitrary approach and we've got users coming with different use-cases (for example - trigger on focus and not on the key+arrow down). The proper solution is to refactor this directive in order to extract a directive's controller and allow people to add custom logic by extending the base typeahead directive. An attempt is here: #888

I'm afraid that this PR can't be merged as-is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants