This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(typeahead): handles min-length of 0 #1372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@chrisirhc I kind of like this one but wanted to quickly check with you before merging. I guess this change is not in conflict with the planned controller - based refactor. |
|
@zacronos sorry for the late response. Would be totally awesome if you could squash those 2 commits and rebase on top of the current master! |
|
Sorry @pkozlowski-opensource my git-fu isn't as strong as it could be -- I had trouble getting it rebased to get this pull request into an ideal state for you. So instead, I've set up a new branch on my fork and got my changes in place with a single commit on top of the current master. The new pull request is #1624. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handles min-length of 0 (i.e. will keep typeahead popup open even when all input has been deleted).