This repository was archived by the owner on May 29, 2019. It is now read-only.
refactor(typeahead): add typeahead controller #1754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, this depends on typeaheadEditable running after the post linking function of the typeahead directive. Note this and solve this later.
|
@pkozlowski-opensource , @ajoslin this is part of #888 for review. |
|
|
||
| //minimal wait time after last character typed before typehead kicks-in | ||
| var waitTime = originalScope.$eval(attrs.typeaheadWaitMs) || 0; | ||
| .controller('typeaheadController', [ |
There was a problem hiding this comment.
Aren't we using Capitalized names for controllers? :P
There was a problem hiding this comment.
We do :-) Plus we should start prefixing those, but this is a separate story.
There was a problem hiding this comment.
Yeah, I was going to say that, that we could start prefixing (for the issue), won't hurt.
There was a problem hiding this comment.
Fixed with caps but I didn't add prefix heh
|
@chrisirhc awesome. Will look into it during the weekend. |
Maintain feature parity. Some duplicate code.
|
+1 |
|
Closing as typeahead is now in a controller - the controller needs to be refactored still, but now it can be done a little more incrementally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to adding typeahead controller. There is some duplicate code but that will be cleaned up in future PRs.