Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

refactor(dropdown): Permit click event propagation. #1987

Closed
wants to merge 1 commit into from

Conversation

bcronje
Copy link

@bcronje bcronje commented Mar 26, 2014

Closes #1986

@chrisirhc
Copy link
Contributor

I haven't looked at this in detail, but would you be able to add a test for this?

@chrisirhc chrisirhc added this to the 0.11.0 milestone Apr 1, 2014
@bcronje
Copy link
Author

bcronje commented Apr 1, 2014

@chrisirhc sure. I should be able to squeeze this in during the next day or two.

if ( self.toggleElement ) {
return self.toggleElement[0];
}
return undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be shortened to return self.toggleElement && self.toggleElement[0].

@bekos
Copy link
Contributor

bekos commented Apr 18, 2014

@bcronje Thx for your PR. #2076 has been landed so we can close this one :-)

@bekos bekos closed this Apr 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropdown-toggle click event.stopPropagation() causes typeahead on same page not to close
3 participants