This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): add open-on-focus option #2515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give an example where opening on focus would be desired? Also, the datepicker seems to have changed quite a bit since this PR was filed - can you rebase your branch off of current master? |
|
Closing due to inactivity will be re-opened once @greenboxal chooses to respond. |
jbthoma
added a commit
to jbthoma/bootstrap
that referenced
this pull request
May 5, 2015
This change is based on angular-ui#2515, except it uses scope.$apply instead of $timeout, and adds datepickerPopupConfig.openOnFocus instead of scope variable @openOnFocus.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the so requested option to open the datepicker popup when the input gets focus.
I understand that it was removed to improve accessibility but in some cases opening on focus is needed.
Also, I'm not sure on how to test this, so I didn't write any unit tests :/