This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): memory leak fix for datepicker. #2684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting find. It looks harmless to do this but I'm curious as to why it fixes the leaks. Thanks @ankit5990 , will look into this very soon. |
|
This might have to do with jQuery's cache. Doing .remove might explicitly remove it from the caching. It also makes sense to set it to null as well as datepickerEl for easier GC. I'll try that and see how the memory performance goes. |
|
I did try making it null as well. Though yes it would help it in an easier GC theoretically, but i did not see any change in memory usage after that. So I just made a minimal fix. |
|
Tested, verified, and merged. Thank you for your excellent find and contribution, @ankit5990 . |
|
happy to contribute :) |
ulle
pushed a commit
to ulle/bootstrap
that referenced
this pull request
Oct 22, 2014
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #2658
Datepicker causes massive memory leaks when used with jquery.
Calling remove on the popupElement that is created by the directive fixes the issue.
Plunkers for comparison of memory before and after the fix added in the issue.