Optimize(dropdownToggle): Cleanup code and increase legibility

[shaungrady]

Not sure why I don't have write access to the bootstrap repo. Is that oversight or is there something I should know before being given permission?

Thank you!

[pkozlowski-opensource]

Ha, the same @shaungrady who wrote native mask for angular-ui :-) Cool stuff, wanted to do it for a while as well, you were faster :-)

Anyway, coming back to the bootstrap, each project has individual teams, adding you to the team if you feel like contributing more. We do things a litle bit different here as build files are not checked in and we never merge pull requests via GitHub to keep the linear history.

On top of this we've got a CI server from the AngularJS team: http://ci.angularjs.org/job/angularui-bootstrap/ so I'm normally merging PRs to a dedicated branch. This way CI kicks in and run tests on several browsers.

[shaungrady]

Thanks! I wasn't aware of the different teams for each project; thanks for explaining it to me. I'd love to be on the team if you'd have me—I'm not sure how much work I'll do in the project, but I'm sure there'll be times that I see things that need to be done.

It wasn't until after I made this PR that I saw there are a couple other issues open about it with included code. This can wait until those issues are resolved: #270 #271

[pkozlowski-opensource]

@shaungrady I've added you to the bootstrap team, welcome!

Going to merge this PR (if tests are passing on the CI) as it makes code better. Other PRs still need some more work (and more importantly - some philosophical decisions) so I think it makes sense to merge this one first.

[pkozlowski-opensource]

Landed as 194c848, thnx!